refactor: unify RpcOpts and EvmArgs common fields #11964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkadrian
requested review from
DaniPopes,
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
mablr
reviewed
Oct 4, 2025
| #[arg(long, value_name = "NO_RATE_LIMITS", visible_alias = "no-rate-limit")] | ||
| #[serde(skip)] | ||
| pub no_rpc_rate_limit: bool, | ||
| } |
There was a problem hiding this comment.
While we do want url, accept_invalid_certs and rpc_timeout in EvmArgs, I'm not sure the other fields are needed/relevant ...
|
@mablr thanks for your review, really appreciate it! I've made changes, did you mean something like this? |
mablr
reviewed
Oct 5, 2025
There was a problem hiding this comment.
Well, yes for the new struct you added. Then deduplicate...
Don't forget that you added new fields to EvmArgs, they must be applied to the provider config spawned when using a command with evm args like forge script (this may help: #11960 (review))
|
|
||
| /// Limited RPC options for EVM-related commands that only need basic RPC functionality. | ||
| #[derive(Clone, Debug, Default, Serialize, Parser)] | ||
| pub struct EvmRpcOpts { |
There was a problem hiding this comment.
I think this should actually be what you called RpcCommonOpts.
Then you could integrate this 3-field struct to both RpcOpts/EvmArgs.
|
|
||
| /// Common RPC-related options that can be shared across different CLI commands. | ||
| #[derive(Clone, Debug, Default, Serialize, Parser)] | ||
| pub struct RpcCommonOpts { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create RpcCommonOpts to share RPC-related fields between RpcOpts and EvmArgs,
resolving serialization conflicts and making the structures compatible.
Fixes #11962